Re: [PATCH 02/11] agp: use NULL instead of 0 when pointer isneeded

From: Jiri Kosina
Date: Tue May 11 2010 - 04:11:43 EST


On Fri, 30 Apr 2010, Bill Pemberton wrote:

> Fixes sparse warning:
>
> drivers/char/agp/generic.c:1217:33: warning: Using plain integer as
> NULL pointer
>
> Signed-off-by: Bill Pemberton <wfp5p@xxxxxxxxxxxx>
> CC: linux-kernel@xxxxxxxxxxxxxxx
> ---
> drivers/char/agp/generic.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c
> index fb86708..4b51982 100644
> --- a/drivers/char/agp/generic.c
> +++ b/drivers/char/agp/generic.c
> @@ -1214,7 +1214,7 @@ struct agp_memory *agp_generic_alloc_user(size_t page_count, int type)
> return NULL;
>
> for (i = 0; i < page_count; i++)
> - new->pages[i] = 0;
> + new->pages[i] = NULL;
> new->page_count = 0;
> new->type = type;
> new->num_scratch_pages = pages;

As this patch isn't present in linux-next as of today, I have applied the
patch to my queue.

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/