Re: [PATCH 2/7] perf trace: Correctly handle arrays

From: Peter Zijlstra
Date: Fri May 14 2010 - 06:39:54 EST


On Thu, 2010-05-13 at 12:32 -0400, Steven Rostedt wrote:
>
> -- Steve
>
> > + else
> > + field->elementsize = field->size;
> > +
> > *fields = field;
> > fields = &field->next;
> >
> > @@ -2101,7 +2109,8 @@ static unsigned long long eval_num_arg(void *data, int size,
> > }
> > right = eval_num_arg(data, size, event, arg->op.right);
> > val = read_size(data + larg->field.field->offset +
> > - right * long_size, long_size);
> > + right * larg->field.field->elementsize,
> > + larg->field.field->elementsize);
> > break;
> > }
> > default_op:
> > diff --git a/tools/perf/util/trace-event.h b/tools/perf/util/trace-event.h
> > index 406d452..cc58a19 100644
> > --- a/tools/perf/util/trace-event.h
> > +++ b/tools/perf/util/trace-event.h
> > @@ -40,6 +40,8 @@ struct format_field {
> > char *name;
> > int offset;
> > int size;
> > + unsigned int arraylen;
> > + unsigned int elementsize;
> > unsigned long flags;
> > };
> >

What's with this new fad of not trimming emails?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/