Re: [PATCH -V8 2/9] vfs: Add name to file handle conversion support

From: J. R. Okajima
Date: Tue May 18 2010 - 02:19:46 EST



"Aneesh Kumar K. V":
> The file_handle I mentioned above is the file handle returned by
> sys_name_to_handle_at syscall. NFS kernel server won't be using the
> interface.

Thanx clarifying.
I think I should read the notes in the first description (0/9) before
posting.
It says UUID is just for userspace.

Reading all 9 patches, I noticed handle_to_path() calls
exportfs_decode_fh() inconditionally.
Since exportfs_decode_fh() calls s_export_op->fh_to_dentry()
inconditionally too, handle_to_path() will crash when the target FS
doesn't support NFS-exporting, won't it?


J. R. Okajima
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/