[PATCH] sysfs: compile fix, struct file forward declaration

From: Chris Wright
Date: Tue May 18 2010 - 18:32:31 EST


On Tue, May 18, 2010 at 04:44:09PM +1000, Stephen Rothwell wrote:
> After merging the driver-core tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> cc1: warnings being treated as errors
> In file included from include/linux/kobject.h:21,
> from include/linux/device.h:17,
> from arch/powerpc/lib/devres.c:10:
> include/linux/sysfs.h:97: error: 'struct file' declared inside parameter list
> include/linux/sysfs.h:97: error: its scope is only this definition or
> declaration, which is probably not what you want
> include/linux/sysfs.h:99: error: 'struct file' declared inside parameter list
> include/linux/sysfs.h:101: error: 'struct file' declared inside parameter list
>
> and many more (arch/powerpc is built with -Werror (as do some other
> architectures)) and lots of similar warnings ...

Add missing forward declaration

Signed-off-by: Chris Wright <chrisw@xxxxxxxxxxxx>
---
include/linux/sysfs.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index 2a0d278..f06b1f1 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -86,6 +86,7 @@ struct attribute_group {

#define attr_name(_attr) (_attr).attr.name

+struct file;
struct vm_area_struct;

struct bin_attribute {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/