Re: [PATCH]460EX on-chip SATA driver <Kernel 2.6.33> < resubmission>

From: Alan Cox
Date: Wed May 19 2010 - 05:46:45 EST


On Wed, 19 May 2010 10:49:59 +0900
Jassi Brar <jassisinghbrar@xxxxxxxxx> wrote:

> On Thu, May 6, 2010 at 2:57 AM, Rupjyoti Sarmah <rsarmah@xxxxxxxx> wrote:
> > This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX.
>
> The controller seems to be a thrid party IP (from Synopsys) in your
> SoC and there are many chances the IP will appear in some other
> SOCs too. This implementation doesn't seem to take care of that
> scenario.

I'd question if that is worth it seriously. At the point there are
multiple users of the device you know what it will look like. Until then
you neither know if the work is needed nor what will require abstracting.

Lazy evaluation is good for code too ;)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/