Re: [GIT PULL] x86/atomic changes for v2.6.35

From: Geert Uytterhoeven
Date: Wed May 19 2010 - 07:46:16 EST


On Tue, May 18, 2010 at 00:45, Ingo Molnar <mingo@xxxxxxx> wrote:
> Please pull the latest x86-atomic-for-linus git tree from:
>
> Â git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git x86-atomic-for-linus
>
>
> out-of-topic modifications in x86-atomic-for-linus:
> ---------------------------------------------------
> lib/Makefile            # 86a8938: lib: Add self-test for atomic64_t
> lib/atomic64.c           # 9757789: lib: Fix atomic64_add_unless retu
> lib/atomic64_test.c        Â# a5c9161: x86, atomic64: In selftest, disti
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â # 25a304f: lib: Fix atomic64_inc_not_zero te
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â # 9efbcd5: lib: Fix atomic64_add_unless test
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â # d7f6de1: x86: Implement atomic[64]_dec_if_
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â # 8f4f202: lib: Only test atomic64_dec_if_po
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â # 86a8938: lib: Add self-test for atomic64_t

Is having atomic64_t mandatory now?

According to the allmodconfig build logs
(http://kisskb.ellerman.id.au/kisskb/matrix/),
several architectures (at least m68k and mips) don't have it.
Furthermore, the test fails to compile on a few architectures that do have it
(parisc, s390, sh, ...).

<boilerplate>
It's a pity this wasn't raised/resolved between its detection in linux-next and
before it entered mainline...
</boilerplate>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/