Re: [PATCH]: bunzip2: Fix warning in get_next_block()

From: Al Viro
Date: Sat May 22 2010 - 10:07:47 EST


On Sat, May 22, 2010 at 10:04:07AM -0400, Prarit Bhargava wrote:
> Fix checkstack compile warning in get_next_block():
>
> lib/decompress_bunzip2.c: In function `get_next_block':
> lib/decompress_bunzip2.c:511: warning: the frame size of 1920 bytes is larger than 1024 bytes

> int dbufCount, nextSym, dbufSize, groupCount, selector,
> - i, j, k, t, runPos, symCount, symTotal, nSelectors,
> - byteCount[256];
> - unsigned char uc, symToByte[256], mtfSymbol[256], *selectors;
> + i, j, k, t, runPos, symCount, symTotal, nSelectors;
> + static int byteCount[256];
> + unsigned char uc, *selectors;
> + static unsigned char symToByte[256], mtfSymbol[256];
> unsigned int *dbuf, origPtr;

Um... Some details might be useful, starting with "why can't that function
be called from several processes at once"...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/