Re: [PATCH -next] nouveau: fix acpi_lid_open undefined

[Randy Dunlap]

On 05/24/10 05:56, Matthew Garrett wrote:
> On Sun, May 23, 2010 at 05:00:40PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>>
>> When CONFIG_ACPI_BUTTON=m (and probably when ACPI_BUTTON is not enabled)
>> and NOUVEAU is built-in (not as a loadable module):
> 
> Won't this result in a behavioural difference? The desirable outcome is 

It could, yes.

> that that configuration be impossible, not for that configuration to 
> build but be buggy.

so nouveau should depend on (or select, if ACPI is enabled) ACPI_BUTTON?


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/