Re: [PATCH 0/4] io-controller: Add new interfaces to trace backloggedgroup status

[Gui Jianfeng]

Vivek Goyal wrote:
> On Mon, May 24, 2010 at 09:12:05AM +0800, Gui Jianfeng wrote:
>> Vivek Goyal wrote:
>>> On Fri, May 21, 2010 at 04:40:50PM +0800, Gui Jianfeng wrote:
>>>> Hi,
>>>>
>>>> This series implements three new interfaces to keep track of tranferred bytes,
>>>> elapsing time and io rate since group getting backlogged. If the group dequeues
>>>> from service tree, these three interfaces will reset and shows zero.
>>> Hi Gui,
>>>
>>> Can you give some details regarding how this functionality is useful? Why
>>> would somebody be interested in only in stats of till group was
>>> backlogged and not in total stats?
>>>
>>> Groups can come and go so fast and these stats will reset so many times
>>> that I am not able to visualize how these stats will be useful.
>> Hi Vivek,
>>
>> Currently, we assign weight to a group, but user still doesn't know how fast the
>> group runs. With io rate interface, users can check the rate of a group at any
>> moment, or to determine whether the weight assigned to a group is enough.
>> bytes and time interface is just for debug purpose.
> 
> Gui,
> 
> I still don't understand that why blkio.sectors or blkio.io_service_bytes
> or blkio.io_serviced interfaces are not good enough to determine at what
> rate a group is doing IO.
> 
> I think we can very well write something in userspace like "iostat" to 
> display the per group rate. Utility can read the any of the above files
> say at the interfval of 1s, calculate the diff between the values and
> display that as group effective rate.

Hi Vivek,

blkio.io_active_rate reflects the rate since group get backlogged, so the rate is a smooth 
value. This value represents the actual rate a group runs. IMO, io rate calculated from
user space is not accurate in following two scenarios:

1 Userspace app chooses the interval of 1s, if 0.5s is backlogged and 0.5s is not, the 
  rate calculated in this interval doesn't make sense.

2 Consider there're several groups are waiting for service, but most part of the interval
  is just fall into the period that the group is under-service. such rate calculated by user
  app isn't acurate, rate burst might occur.

Further more, once max weight control is available, we can make use of such interface to realize
how well this group works.

Thanks,
Gui


> 
> Thanks
> Vivek
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/