Re: [PATCH] drm/i915: Convert more trace events to DEFINE_EVENT

[Steven Rostedt]

On Mon, 2010-05-24 at 16:25 +0800, Li Zefan wrote:
> Convert i915_gem_object_clflush to DEFINE_EVENT, and save ~0.5K:
> 
>    text    data     bss     dec     hex filename
>   13204    2732      12   15948    3e4c i915_trace_points.o.orig
>   12668    2732      12   15412    3c34 i915_trace_points.o
> 
> No change in functionality.
> 

Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

I'm expecting that this will be going through the DRM/i915 path.

-- Steve

> Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/i915_trace.h |   24 +++++++-----------------
>  1 files changed, 7 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> index 9e4c45f..fab2176 100644
> --- a/drivers/gpu/drm/i915/i915_trace.h
> +++ b/drivers/gpu/drm/i915/i915_trace.h
> @@ -53,23 +53,6 @@ TRACE_EVENT(i915_gem_object_bind,
>  		      __entry->obj, __entry->gtt_offset)
>  );
>  
> -TRACE_EVENT(i915_gem_object_clflush,
> -
> -	    TP_PROTO(struct drm_gem_object *obj),
> -
> -	    TP_ARGS(obj),
> -
> -	    TP_STRUCT__entry(
> -			     __field(struct drm_gem_object *, obj)
> -			     ),
> -
> -	    TP_fast_assign(
> -			   __entry->obj = obj;
> -			   ),
> -
> -	    TP_printk("obj=%p", __entry->obj)
> -);
> -
>  TRACE_EVENT(i915_gem_object_change_domain,
>  
>  	    TP_PROTO(struct drm_gem_object *obj, uint32_t old_read_domains, uint32_t old_write_domain),
> @@ -132,6 +115,13 @@ DECLARE_EVENT_CLASS(i915_gem_object,
>  	    TP_printk("obj=%p", __entry->obj)
>  );
>  
> +DEFINE_EVENT(i915_gem_object, i915_gem_object_clflush,
> +
> +	    TP_PROTO(struct drm_gem_object *obj),
> +
> +	    TP_ARGS(obj)
> +);
> +
>  DEFINE_EVENT(i915_gem_object, i915_gem_object_unbind,
>  
>  	    TP_PROTO(struct drm_gem_object *obj),


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/