Re: [PATCH] touchscreen: ads7846: please don't touch free'd memory

From: Mike Frysinger
Date: Tue May 25 2010 - 18:02:16 EST


On Tue, May 25, 2010 at 17:46, Kevin Hilman wrote:
> After digging into the driver core and realizing that it seemed to
> have sane error handling itself, I took a closer look at
> ads7846_probe() and discovered it doesn't actually return an error
> code for certain failure cases! ÂThat was the root cause.

that is crappy

> Subject: [PATCH] input: touchscreen: ads7846: return error on probe failure

i'd refer to the specific probe issue rather than just "probe". maybe:
input: touchscreen: ads7846: return error on regulator_get() failure

otherwise:
Acked-by: Mike Frysinger <vapier@xxxxxxxxxx>
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/