Re: [PATCH] arch/tile: new multi-core architecture for Linux

[Chris Metcalf]

On 5/25/2010 10:44 PM, liqin.chen@xxxxxxxxxxxxx wrote:
> Arnd Bergmann <arnd@xxxxxxxx>  at 2010-05-25 23:03:11
>>> - You renamed __NR__llseek to __NR_llseek, which of course seems pretty
>>>       
>>> reasonable, but libc expects to see the former (both glibc and uclibc). 
>>>       
>>> Is it worth requiring non-standard libc code?  I may just add
>>> __NR__llseek as an alias in my unistd.h for now.
>>>       
>> That was probably just a mistake on my side. The only other
>> architecture using the generic version so far is score, so
>> maybe Chen Liqin can comment on how he dealt with this and
>> if he depends on the definition now.
>>     
> When we port glibc to score arch, we fixed the llseek.c file,
> remove the underscore before llseek. maybe it has compatible problems, 
> but it work ok with score application.
>   

This sounds like the right solution for the generic code too, but
presumably it would need some kind of "#if !defined(__NR_llseek) &&
defined(__NR__llseek)" hackery in the llseek.c common code in glibc.
Ulrich, does that seem like the right direction for you?

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/