Re: [GIT PULL 0/2] perf annotate fix and report improvoment

[Stephane Eranian]

On Wed, May 26, 2010 at 10:33 PM, Arnaldo Carvalho de Melo
<acme@xxxxxxxxxxxxx> wrote:
> Em Wed, May 26, 2010 at 10:11:14PM +0200, Stephane Eranian escreveu:
>> On Wed, May 26, 2010 at 9:32 PM, Arnaldo Carvalho de Melo
>> <acme@xxxxxxxxxxxxx> wrote:
>> > Em Wed, May 26, 2010 at 09:07:05PM +0200, Stephane Eranian escreveu:
>> >> But in this example, I only really care about the symbols in the
>> >> noploop program (/tmp/noploop).
>> >>
>> >> Missing symbol support for the kernel should not cause perf to avoid
>> >> trying to resolve the symbols in other modules such as my user program
>> >> here.
>> >
>> > Right, my bad, I thought that the problem was about the kernel symbols.
>> >
>> > Then can you try replacing:
>> >
>> > perf annotate -i ~/perf.data noploop
>> >
>> > with:
>> >
>> > perf annotate -i ~/perf.data -d noploop
>> >
>> > And see if that helps?
>> >
>> Ok that works. But if I turned on TUI, then I cannot obtain
>> the same result. I am guessing it does not use the -d option.
>
> Humm, it should be working, i.e. -d processing is about adding a filter,
> lemme see...
>
> Yeah, in builtin-annotate.c
>
> Â Â Â ÂOPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]",
> Â Â Â Â Â Â Â Â Â "only consider symbols in these dsos"),
>
> It sets the dso_list_str and that is used when processing events in:
>
> Â Â Â Âperf_session__process_events
> Â Â Â Â Â Â Â Âprocess_sample_event (in builtin-annotate.c)
> Â Â Â Â Â Â Â Â Â Â Â Âevent__preprocess_sample
>
> In event__preprocess_sample:
>
> Â Â if (symbol_conf.dso_list &&
> Â Â Â Â (!al->map || !al->map->dso ||
> Â Â Â Â Â!(strlist__has_entry(symbol_conf.dso_list,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â al->map->dso->short_name) ||
> Â Â Â Â Â Â(al->map->dso->short_name != al->map->dso->long_name &&
> Â Â Â Â Â Â strlist__has_entry(symbol_conf.dso_list,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âal->map->dso->long_name)))))
> Â Â Â Â Â Â goto out_filtered;
>
> Yeah, this is all done no matter what frontend is used :-\
>
> I just tried it here with:
>
> [root@emilia linux-2.6-tip]# perf report -d libc-2.12.so
> [root@emilia linux-2.6-tip]# perf annotate -d libc-2.12.so
>
> with
>
> [root@emilia linux-2.6-tip]# cat ~/.perfconfig
> [tui]
>
> Â Â Â Âreport = on
> Â Â Â Âannotate = on
> [root@emilia linux-2.6-tip]#
>
> And it works as expected.
>
I did not explain my testcase enough ;-<

With TUI, I started from perf report -i perf.data, then chose to zoom into
the noploop symbol.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/