Re: [PATCH] perf: fix use_browser infinite loop bug in annotate

From: Arnaldo Carvalho de Melo
Date: Thu May 27 2010 - 11:45:59 EST


Em Thu, May 27, 2010 at 11:51:42AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, May 27, 2010 at 02:50:01PM +0200, Stephane Eranian escreveu:
> > This patch fixes an infinite loop problem with perf annotate when
> > the TUI is not used. When the perfconfig file is not found use_browser
> > remains at -1, when found and tui is disabled use_browser = 0. Thus the
> > correct test for TUI is use_browser > 0.
> >
> > Signed-off-by: Stephane Eranian <eranian@xxxxxxxxxx>
>
> Thanks, I'm applying this one and doing an audit of other uses, I know
> of one more case reported by Frédéric that was fixed in a similar way.

Oops, I already have this fixed on changeset

62e3436b5f3461662929eae102beefbd12127cb1

That is at:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf

http://git.kernel.org/?p=linux/kernel/git/acme/linux-2.6.git;a=commit;h=62e3436b5f3461662929eae102beefbd12127cb1

I pushed this to Ingo yesterday, should be in tip/perf/core soon,
thanks anyway!

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/