Re: [PATCH] fs: run emergency remount on dedicated workqueue

[Tejun Heo]

On 05/27/2010 04:59 PM, Américo Wang wrote:
> On Thu, May 27, 2010 at 11:57:23AM +0200, Tejun Heo wrote:
>> Commit fa4b9074cd8428958c2adf9dc0c831f46e27c193 made s_umount depend
>> on keventd; however, emergency remount schedules works to keventd
>> which grabs s_umount creating a circular dependency.  Run emergency
>> remount on a separate workqueue to break it.
>>
> 
> I have a stupid question, why using workqueue instead of
> calling do_remount_sb() directly in emergency_remount()?
> Avoid blocking emergency_remount()?

Umm... because it's called from interrupt handler?  Right?

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/