Re: [PATCH 1/3] sys_personality: validate personality beforeset_personality()

From: Andi Kleen
Date: Thu May 27 2010 - 14:18:43 EST


On Thu, May 27, 2010 at 10:51:46AM -0700, Linus Torvalds wrote:
>
>
> On Thu, 27 May 2010, Oleg Nesterov wrote:
> >
> > But. Suppose an application does personality(0xffffffff << 32) on x86_64.
> >
> > Before this patch we return -EINVAL (but wrongly change ->personality).
> > After this patch this is equal to personality(0), right?
>
> Yes. And I'm willing to take that "risk" in the name of not having to
> carry crazy stuff around in the kernel.

Perhaps we can have a personality with the old personality behaviour @)

Just joking, I doubt anything really cares. I don't think personality
was used much in 64bit except for uname emulation.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/