Re: [v5 Patch 1/3] netpoll: add generic support for bridge andbonding devices

From: Flavio Leitner
Date: Thu May 27 2010 - 17:25:32 EST


On Thu, May 27, 2010 at 01:35:59PM -0700, David Miller wrote:
> From: Flavio Leitner <fbl@xxxxxxxxxxxx>
> Date: Thu, 27 May 2010 15:05:45 -0300
>
> > I did the following patch to discard the packet if it was IN_NETPOLL
> > and the read_lock() fails, so I could go ahead testing it:
>
> This is disgusting, let's just disallow console output from such
> locations. Defer them to a workqueue if their output is so critical.

I did that patch just to see the backtrace in the serial console
and to keep testing it. It's not a solution at all.

Just to be clear, the second problem isn't related to that patch
and the console message is already in a workqueue.

--
Flavio
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/