Re: [linux-pm] [patch] complain when users abuse the pm_qos API

From: Rafael J. Wysocki
Date: Sun May 30 2010 - 15:49:04 EST


On Sunday 30 May 2010, Nigel Cunningham wrote:
> Hi.
>
> On 30/05/10 06:08, Rafael J. Wysocki wrote:
> > On Saturday 29 May 2010, mark gross wrote:
> >> The following patch is to help clean up API abusers of pm_qos where
> >> they call update_request before registering a request.
> >>
> >> --mgross
> >>
> >> --Signed-off-by: markgross<markgross@xxxxxxxxxxx>
> >
> > Will there be a big issue if I push this during the next merge window?
>
> What's the point to the patch? That is: why is calling update_request
> before registering a request such a big problem that it demands a WARN()
> and dump stack?

It is an API violation if I understand that correctly.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/