Re: [Uclinux-dist-devel] [PATCH] NOMMU: Add '[stack]' label to /proc/pid/maps output

[Mike Frysinger]

On Tue, Jun 1, 2010 at 15:07, Linus Torvalds wrote:
> On Tue, 1 Jun 2010, David Howells wrote:
>> Add support to the NOMMU /proc/pid/maps file to show which mapping is the stack
>> of the original thread after execve. ÂThis is largely based on the MMU code.
>
> Umm? The MMU code that we _reverted_?

to be fair, this patch was written a few kernel revisions ago and
you're referring to commit merged a few weeks ago ...

> It turns out to be totally useless, since people put stacks in various
> different places, and the values the kernel does see end up not even being
> the "real" stack top.
>
> See commit 34441427aab4bdb3069a4ffcda69a99357abcb2e.
>
> Just don't do it.

but i dont think we're talking the same thing.  that commit refers to
[threadstack].  afaict, [stack] is still in there.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/