RE: [linux-pm] [PATCH 0/8] Suspend block api (version 8)

[Gross, Mark]

>-----Original Message-----
>From: Arve Hjønnevåg [mailto:arve@xxxxxxxxxxx]
>Sent: Tuesday, June 01, 2010 8:15 PM
>To: Gross, Mark
>Cc: James Bottomley; Rafael J. Wysocki; Matthew Garrett; Thomas Gleixner;
>Peter Zijlstra; tytso@xxxxxxx; LKML; Florian Mickler; Linux PM; Linux OMAP
>Mailing List; felipe.balbi@xxxxxxxxx; Alan Cox; Alan Stern; Neil Brown
>Subject: Re: [linux-pm] [PATCH 0/8] Suspend block api (version 8)
>
>2010/6/1 Gross, Mark <mark.gross@xxxxxxxxx>:
>...
>>>4. It would be useful to change pm_qos_add_request to not allocate
>>>anything so can add constraints from init functions that currently
>>>cannot fail.
>> [mtg: ] I'm not sure how to do this but I agree it would be good.  I
>guess we could have a block of pm_qos requests pre-allocated statically and
>re-use them.  In practice there will not be more than a handful of requests
>ever.  Dynamic allocation does seem like a bit of a waste.
>
>The calling code will have to store a pointer to your structure
>anyway, you may as well have them provide the whole structure.
[mtg: ] duh!  You are right.  Make the caller's hold the structure.  Its been a long day.  That would be easy todo.

--gmross


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/