Re: [PATCH] binfmt_elf_fdpic: Fix clear_user() error handling

[Paul Mundt]

On Tue, Jun 01, 2010 at 02:10:47PM +0100, David Howells wrote:
> From: Takuya Yoshikawa <yoshikawa.takuya@xxxxxxxxxxxxx>
> 
> clear_user() returns the number of bytes that could not be copied rather than
> an error code.  So we should return -EFAULT rather than directly returning the
> results.
> 
> Without this patch, positive values may be returned to elf_fdpic_map_file()
> and the following error handlings do not function as expected.
> 
> 1.
> 	ret = elf_fdpic_map_file_constdisp_on_uclinux(params, file, mm);
> 	if (ret < 0)
> 		return ret;
> 2.
> 	ret = elf_fdpic_map_file_by_direct_mmap(params, file, mm);
> 	if (ret < 0)
> 		return ret;
> 
> Signed-off-by: Takuya Yoshikawa <yoshikawa.takuya@xxxxxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> Acked-by: Mike Frysinger <vapier@xxxxxxxxxx>
> CC: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>
> CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> CC: Daisuke HATAYAMA <d.hatayama@xxxxxxxxxxxxxx>
> CC: Paul Mundt <lethal@xxxxxxxxxxxx>

Acked-by: Paul Mundt <lethal@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/