Re: [Uclinux-dist-devel] [PATCH v2] regulator: new drivers forAD5398 and AD5821

[Mark Brown]

On Wed, Jun 02, 2010 at 05:02:58AM -0400, Mike Frysinger wrote:

> > +       dev_dbg(&client->dev, "%s regulator driver loaded\n", id->name);

> does the regulator core take care of displaying a notice ?  if not,
> i'd make this dev_info().  also, this should be "registered", not
> "loaded".

A message will be displayed if the device actually has any constraints
(and is therefore in use) so if it makes any difference to the system
there will be some chat.

> > +MODULE_DESCRIPTION("AD5398 and AD5821 current regulator driver");
> > +MODULE_AUTHOR("Sonic Zhang");
> > +MODULE_LICENSE("GPL");

> should there be a MODULE_ALIAS() ?

Possibly, though it's unlikely that actual systems will ever build a
regulator they're using as a module.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/