Re: [PATCH] panic: keep blinking in spite of long spin timer mode

[TAMUKI Shoichi]

Hello,

Thank you for the suggestion.

On Sun, 30 May 2010 08:55:22 +0200 Andi Kleen wrote:

> Thanks for this explanation, makes all sense.
> But should do these changes by default then, not with a parameter.

Hmm, that will not be acceptable since the control of blinking speed
becomes difficult with long spin timer mode.

However, I agree to your opinion that it is not the best answer to
prepare purposely a new parameter for such a rare situation.

> Changing the frequency is ok, the only requirement is that it is
> visible and different from the frequency kdb uses.

So, I changed that the time calls to mdelay will be automatically
switched to longer if the speed of blinking is slow enough.  The
kernel parameter (panic_longspin) becomes no longer necessary.

I will soon post the PATCH v2.

Regards,
TAMUKI Shoichi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/