Re: [PATCH 09/12] oom: remove PF_EXITING check completely

[David Rientjes]

On Fri, 4 Jun 2010, Oleg Nesterov wrote:

> > > > > Currently, PF_EXITING check is completely broken. because 1) It only
> > > > > care main-thread and ignore sub-threads
> > > >
> > > > Then check the subthreads.
> > > >
> >
> > Did you want to respond to this?
> 
> Please explain what you mean. There were already a lot of discussions
> about mt issues, I do not know what you have in mind.
> 

Can you check the subthreads to see if they are not PF_EXITING?

> > I'm guessing at the relevancy here because the changelog is extremely
> > poorly worded (if I were Andrew I would have no idea how important this
> > patch is based on the description other than the alarmist words of "... is
> > completely broken)", but if we're concerned about the coredumper not being
> > able to find adequate resources to allocate memory from, we can give it
> > access to reserves specifically,
> 
> I don't think so. If oom-kill wants to kill the task which dumps the
> code, it should stop the coredumping and exit.
> 

That's a coredump change, not an oom killer change.  If the coredumper 
needs memory and runs into the oom killer, this PF_EXITING check, which 
you want to remove, gives it access to memory reserves by setting 
TIF_MEMDIE so it can quickly finish and die.  This allows it to exit 
without oom killing anything else because the tasklist scan in the oom 
killer is not preempted by finding a TIF_MEMDIE task.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/