Re: [PATCH] p54spi: replace internal "cx3110x" name with "p54spi"

From: Johannes Berg
Date: Fri Jun 04 2010 - 04:37:00 EST


On Wed, 2010-06-02 at 14:06 -0500, Luke-Jr wrote:

> > > .driver = {
> > > - /* use cx3110x name because board-n800.c uses that for the
> > > - * SPI port */
> > > - .name = "cx3110x",
> > > + .name = "p54spi",
> > > .bus = &spi_bus_type,
> >
> > maybe that comment wasn't clear enough ... it needs to be that way to be
> > properly linked up against SPI.
>
> I don't understand what you mean here. Does the hardware-side of SPI use
> string identifiers? These are the only two instances of "cx3110x" in the
> kernel source; N8x0 board files expect "p54spi"

Hm, ok, I thought that the board stuff needed cx3110x. Hopefully it
doesn't differ in n810s?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/