Re: [PATCH 1/1] LEDS: leds-input, fix sleep inside atomic

From: Samuel Thibault
Date: Sat Jun 05 2010 - 19:45:17 EST


Jiri Slaby, le Sat 05 Jun 2010 23:12:22 +0200, a écrit :
> Fix this by changing the spinlock to mutex as it is used only in
> input_handler->connect and ->disconnect and it is safe to sleep
> there.

Right. in a previous patch it was also used in interrupt context, but
now it should be safe indeed.

Andrew, please fold it into the leds-input patch.

> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Richard Purdie <rpurdie@xxxxxxxxx>
Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

BTW, please also Cc authors of files when reporting bugs... :)

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/