Re: [linux-pm] suspend blockers & Android integration

From: Brian Swetland
Date: Sun Jun 06 2010 - 15:15:37 EST


On Sun, Jun 6, 2010 at 12:05 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Sun, Jun 06, 2010 at 12:08:34PM -0500, James Bottomley wrote:
>> Well, we sort of tried this when Greg pulled some of them into the
>> staging tree. ÂThe problem is that without the annotations, the drivers
>> are still different, and patches won't apply, so, unsurprisingly, they
>> didn't get improved or even maintained.
>
> Err, the biggest pile in staging was meta drivers like the binder or
> some oom killer magic which are flat out braindead and wrong and have
> no chance going into mainline anyway. ÂThat's something different from
> real hardware drivers, although a few of those made it into staging as
> well if I remember correctly.

I was shocked when Greg pulled the binder driver and some of the other
"generic" android drivers into staging, because it was always my
assumption that nobody upstream would want them. We did get some
bugfixes for the binder driver (thanks!) but the general reaction was
pretty much the same as yours here. I then was relatively unsurprised
when it was dropped (we find it useful, upstream finds it useless, not
much else to say).

The various SoC peripheral drivers are, I suspect, much less
contentious (modulo suspend blocker usage and any necessary kernel
style cleanup).

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/