Re: [PATCH 2/2] mmc: fix mmc card disappearence on resume on ricohmmc controllers

[Maxim Levitsky]

On Mon, 2010-06-07 at 00:23 +0100, Chris Ball wrote: 
> Hi,
> 
> On Mon, Jun 07, 2010 at 12:28:51AM +0300, Maxim Levitsky wrote:
> > +	/* Some controllers (especialy the ricoh mmc controller) delay
> > +		card detection on resume (probably since the controller
> > +		has to poke the card to determine if its MMC or not */
> > +
> > +	if (host->mmc->bus_ops && (host->quirks &
> > +			SDHCI_QUIRK_WAIT_CARD_ON_RESUME)) {
> > +
> > +		unsigned long timeout = jiffies + msecs_to_jiffies(2000);
> > +
> > +		while (!time_after(jiffies, timeout))
> > +			if (sdhci_readl(host, SDHCI_PRESENT_STATE)
> > +							& SDHCI_CARD_PRESENT) {
> > +				break;
> 
> It looks like your editor is set to four-space instead of eight-space
> tab characters, else you wouldn't be using so many tabs here. 
Nope, I think indention is right here.

the break is inside 'if' condition.

Best regards
Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/