Re: 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection!

From: Peter Zijlstra
Date: Wed Jun 09 2010 - 17:21:29 EST


On Wed, 2010-06-09 at 17:15 -0400, Miles Lane wrote:
> On Wed, Jun 9, 2010 at 2:15 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > On Wed, 2010-06-09 at 19:57 +0200, Peter Zijlstra wrote:
> >> + /*
> >> + * We're not in the pid-hash yet so no cgroup attach races, and the
> >> + * cgroup is pinned by the parent running this.
> >> + *
> >> + * Silence PROVE_RCU.
> >> + */
> >
> > Hum,.. not sure that's actually true though, the parent itself is still
> > susceptible to races afaict..
>
> Do you want what you sent earlier tested, or should I wait for another patch?

please wait, I need to sit down and sort out that code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/