[PATCH] [10/23] SCHED: Only allocate per cpu cpu mask buffer with offstack cpumasks

From: Andi Kleen
Date: Thu Jun 10 2010 - 07:10:55 EST



This will save a few bytes in the non offstack cpumask case.

Found by gcc 4.6's new warnings.

Cc: peterz@xxxxxxxxxxxxx
Cc: mingo@xxxxxxx
Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

---
kernel/sched.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

Index: linux-2.6.35-rc2-gcc/kernel/sched.c
===================================================================
--- linux-2.6.35-rc2-gcc.orig/kernel/sched.c
+++ linux-2.6.35-rc2-gcc/kernel/sched.c
@@ -7482,7 +7482,7 @@ static void init_tg_rt_entry(struct task
void __init sched_init(void)
{
int i, j;
- unsigned long alloc_size = 0, ptr;
+ unsigned long alloc_size = 0;

#ifdef CONFIG_FAIR_GROUP_SCHED
alloc_size += 2 * nr_cpu_ids * sizeof(void **);
@@ -7494,7 +7494,10 @@ void __init sched_init(void)
alloc_size += num_possible_cpus() * cpumask_size();
#endif
if (alloc_size) {
+#ifdef CONFIG_CPUMASK_OFFSTACK
+ unsigned long ptr;
ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);
+#endif

#ifdef CONFIG_FAIR_GROUP_SCHED
init_task_group.se = (struct sched_entity **)ptr;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/