Re: [PATCH 1/5] perf: Provide a proper stop action for softwareevents

From: Peter Zijlstra
Date: Sat Jun 12 2010 - 05:43:36 EST


On Sat, 2010-06-12 at 09:34 +0200, Frederic Weisbecker wrote:
> In order to introduce new context exclusions, software events will
> have to eventually stop when needed. We'll want perf_event_stop() to
> act on every events.
>
> To achieve this, remove the stub stop/start pmu callbacks of software
> and tracepoint events that fixed a race in perf_adjust_period, and do
> an explicit check to only reset the hardware event using the
> start/stop callbacks.

I really object to this,. its just too ugly to live.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/