Re: [PATCH 2/4] x86: ioremap: fix physical address check

[Kenji Kaneshige]

(2010/06/15 3:36), H. Peter Anvin wrote:
> On 06/14/2010 04:06 AM, Kenji Kaneshige wrote:
> > Index: linux-2.6.34/include/linux/vmalloc.h
> > ===================================================================
> > --- linux-2.6.34.orig/include/linux/vmalloc.h
> > +++ linux-2.6.34/include/linux/vmalloc.h
> > @@ -30,7 +30,7 @@ struct vm_struct {
> >   	unsigned long		flags;
> >   	struct page		**pages;
> >   	unsigned int		nr_pages;
> > -	unsigned long		phys_addr;
> > +	phys_addr_t		phys_addr;
> >   	void			*caller;
> >   };
>
> This really doesn't look right at all.  If this was required then it
> would seem that anything using high addresses would be broken... as such
> I can only assume it matters only for lowmem pages...

Without this change, /pric/vmallocinfo doesn't display physcal address info
properly (need also to change s_show() in mm/vmalloc (%lx in seq_printf()).

Thanks,
Kenji Kaneshige

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/