Re: [PATCH] avoid using smp_processor_id() in preemptible code(nr_iowait_cpu)

From: Arjan van de Ven
Date: Tue Jun 15 2010 - 11:05:44 EST


On Tue, 15 Jun 2010 17:50:29 +0300
Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> wrote:
> >
> > hmm this part is wrong
> > you pick the current cpu, rather than the one denoted by ts.....
> >
>
> Hmm. Thanks, good catch.
> Well, there is something I'm missing. How can I match given *ts and
> cpu in update_ts_time_stats (except for introducing
> update_ts_time_stats(..., int cpu)) ?


that'd be option one
option two is to add a "cpu" member to struct tick_sched.....

if you go for option one, I'd replace the ts argument with the cpu
argument.....


--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/