RE: [PATCH v3] drivers: regulator: add Maxim 8998 driver

[Marek Szyprowski]

Hello,

On Wednesday, June 16, 2010 4:31 PM Mark Brown wrote:

> On Wed, Jun 16, 2010 at 09:04:16AM +0200, Marek Szyprowski wrote:
> > From: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> >
> > This patch adds voltage regulator driver for Maxim 8998 chip. This chip
> > is used on Samsung Aquila and GONI boards and provides following
> > functionalities:
> > - 4 BUCK voltage converters, 17 LDO power regulators and 5 other power
> >   controllers
> > - battery charger
> >
> > This patch adds basic driver for voltage regulators and MAX 8998 MFD core.
> >
> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> 
> Looks good!
> 
> Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

I've just noticed one more thing. Shouldn't the max8998-pmic driver depend
on max8998 mfd driver in Kconfig? Or maybe it would be better to select mfd
driver from the regulators Kconfig? What do you think? 

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/