Re: [PATCH] Staging: comedi: fix over 80 character coding styleissues in ni_labpc.c

[Joe Perches]

On Thu, 2010-06-17 at 13:36 -0700, Greg KH wrote:
> On Sat, May 29, 2010 at 10:05:44AM +0100, Maurice Dawson wrote:
> > This is a patch to the ni_labpc.c file that fixes most over 80
> > character warnings found by the checkpatch.pl tool. Two lines, 4 and
> > 1035 have not been changed because readability is better and no
> > information is hidden
> > --- a/drivers/staging/comedi/drivers/ni_labpc.c
> > +++ b/drivers/staging/comedi/drivers/ni_labpc.c
> > @@ -738,7 +738,8 @@ static int labpc_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> >  		break;
> >  	case pcmcia_bustype:
> >  		printk
> > -		    (" this driver does not support pcmcia cards, use ni_labpc_cs.o\n");
> > +		    ("this driver does not support pcmcia cards, "
> > +							"use ni_labpc_cs.o\n");
> 
> Ick, no, don't break these types of strings.  Newer versions of
> checkpatch will not complain about this.

Hi Greg.

Unfortunately, currently checkpatch will complain about
this sort of line because the format string is not on the
same line as the printk.

This line should become something like:

		pr_err(" this driver does not support pcmcia cards, use ni_labpc_cs\n");
or
		comedi_err(etc...);

if ever the comedi_<level> printk helper macros are accepted.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/