Re: [PATCHv5 06/11] USB: gadget: g_multi: code clean up and refactoring

[MichaÅ Nazarewicz]

On Thu, 17 Jun 2010 19:51:01 +0200, Greg KH <greg@xxxxxxxxx> wrote:

> On Wed, Jun 16, 2010 at 12:08:01PM +0200, Michal Nazarewicz wrote:
> > The Multifunction Compasite Gadget have been cleaned up
> > and refactored so hopefully it looks prettier and works
> > at least as good as before changes.
> >
> > Signed-off-by: Michal Nazarewicz <m.nazarewicz@xxxxxxxxxxx>
> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> > ---
> >  drivers/usb/gadget/Kconfig |    1 +
> >  drivers/usb/gadget/multi.c |  262 +++++++++++++++++++++++++-------------------
> >  2 files changed, 148 insertions(+), 115 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> > index 591ae9f..027f61b 100644
> > --- a/drivers/usb/gadget/Kconfig
> > +++ b/drivers/usb/gadget/Kconfig
> > @@ -863,6 +863,7 @@ config USB_G_NOKIA
> >  config USB_G_MULTI
> >  	tristate "Multifunction Composite Gadget (EXPERIMENTAL)"
> >  	depends on BLOCK && NET
> > +	select USB_G_MULTI_CDC if !USB_G_MULTI_RNDIS
> >  	help
> >  	  The Multifunction Composite Gadget provides Ethernet (RNDIS
> >  	  and/or CDC Ethernet), mass storage and ACM serial link
>
> Why is this change needed?  Did you do something else in this patch that
> requires it?

Without this select it is possible to choose neither RNDIS nor CDC ECM which
in turns builds a module with no configurations.

I've also realised recently that one does not need to specify
bNumConfigurations in usb_device_descriptor since composite counts that for
us so I'll resend this patch with that fixed as well.

--
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  MichaÅ "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/