Re: [RFC 1/3] Unified NMI delayed call mechanism

[Peter Zijlstra]

On Sat, 2010-06-12 at 17:28 +0800, Huang Ying wrote:
> +#define NMI_DELAYED_CALL_ID_MAX                32
> +#define NMI_DELAYED_CALL_RESTART_MAX   5
> +
> +static nmi_delayed_call_func_t nmi_delayed_call_funcs[NMI_DELAYED_CALL_ID_MAX];
> +static DEFINE_SPINLOCK(nmi_delayed_call_lock);
> +
> +static DEFINE_PER_CPU(unsigned long, nmi_delayed_call_pending);
> +
> +static void nmi_delayed_call_run(void)
> +{
> +       int cpu, restart = NMI_DELAYED_CALL_RESTART_MAX;
> +       unsigned long pending, *ppending;
> +       nmi_delayed_call_func_t *pfunc, func;
> +
> +       cpu = smp_processor_id();
> +       ppending = per_cpu_ptr(&nmi_delayed_call_pending, cpu);
> +       while (*ppending && restart--) {
> +               pending = xchg(ppending, 0);
> +               pfunc = nmi_delayed_call_funcs;
> +               do {
> +                       if (pending & 1) {
> +                               func = *pfunc;
> +                               if (func)
> +                                       func();
> +                       }
> +                       pfunc++;
> +                       pending >>= 1;
> +               } while (pending);
> +       }
> +}

So aside from the should this be perf or not, the above is utter
gibberish. Whoever came up with this nonsense?

Why not make a work_struct like thing and enqueue it using cmpxchg on a
percpu list, then have the interrupt process them. Read
perf_pending_queue() and __perf_pending_run().

That way you don't need this whole register/id/limit crap.

> +#ifdef CONFIG_X86_LOCAL_APIC

What's the point of the rest of this code if we don't have a lapic?

> +asmlinkage void smp_nmi_delayed_call_interrupt(struct pt_regs *regs)
> +{
> +       ack_APIC_irq();
> +       irq_enter();

You're missing inc_irq_stat() there.

> +       nmi_delayed_call_run();
> +       irq_exit();
> +}
> +#endif 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/