Re: [PATCH] cfq-iosched: Fixed boot warning with BLK_CGROUP=y andCFQ_GROUP_IOSCHED=n

From: Ingo Molnar
Date: Sun Jun 20 2010 - 04:10:48 EST



* Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:

> Hi Jens,
>
> Few days back Ingo noticed a CFQ boot time warning. This patch fixes it.

Hm, have you tested it? This bit:

> +++ linux-2.6/block/cfq.h 2010-06-18 09:41:23.256220395 -0400

> +static inline void cfq_blkiocg_update_completion_stats(struct blkio_group *blkg, uint64_t start_time, uint64_t io_start_time, bool direction, bool sync)
> +{
> + cfq_blkiocg_update_completion_stats(blkg, start_time, io_start_time,
> + direction, sync);
> +}

is an inline function calling itself.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/