Re: [PATCH] drivers/media/IR/imon.c: Use pr_err instead of err

From: Jarod Wilson
Date: Sun Jun 20 2010 - 11:59:07 EST


On Jun 20, 2010, at 3:20 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:

Use the standard error logging mechanisms.
Add #define pr_fmt(fmt) KBUILD_MODNAME ":%s" fmt, __func__
Remove __func__ from err calls, add '\n', rename to pr_err

Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
---

Eh. If we're going to make a change here, I'd rather it be to using dev_err instead, since most of the other spew in this driver uses similar.

--
Jarod Wilson
jarod@xxxxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/