Re: [PATCH 3/6 v2]cifs Fix warnings variables set but not used

From: Jeff Layton
Date: Sun Jun 20 2010 - 20:26:23 EST


On Sun, 20 Jun 2010 15:33:54 -0700
"Justin P. Mattock" <justinmattock@xxxxxxxxx> wrote:

>
> >> /* since paths are not looked up by component - the parent
> >> directories are presumed to be good here */
> >> renew_parental_timestamps(direntry);
> >> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> >> index 75541af..73e540b 100644
> >> --- a/fs/cifs/file.c
> >> +++ b/fs/cifs/file.c
> >> @@ -1312,7 +1312,7 @@ static int cifs_partialpagewrite(struct page *page, unsigned from, unsigned to)
> >> int rc = -EFAULT;
> >> int bytes_written = 0;
> >> struct cifs_sb_info *cifs_sb;
> >> - struct cifsTconInfo *pTcon;
> >> + struct cifsTconInfo *pTcon __attribute__((unused));
> >
> > This variable can just be removed (along with the spot where it gets
> > set later).
> >
> >> struct inode *inode;
> >> struct cifsFileInfo *open_file;
> >>
> >
> >
>
> one thing I want to make sure of before sending this out, is with file.c
> if I remove *pTcon another warning shows up:
>
> CC [M] fs/cifs/file.o
> fs/cifs/file.c: In function 'cifs_partialpagewrite':
> fs/cifs/file.c:1314:23: warning: variable 'cifs_sb' set but not used
>
> with the original patch I had removed this as well, should I do this or
> is this not a good idea?

If it's not used, remove it...

--
Jeff Layton <jlayton@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/