Re: [PATCH UPDATED] sched: adjust when cpu_active and cpuset configurationsare updated during cpu on/offlining

From: Tejun Heo
Date: Mon Jun 21 2010 - 18:03:04 EST


Hello,

On 06/21/2010 11:46 PM, Tony Luck wrote:
> On Mon, Jun 21, 2010 at 2:20 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
>> I'm primarily curious why different archs are doing things
>> differently, which causes confusion and reduces test coverage. Also,
>> if you just think about the end result, what x86 is doing makes more
>> sense. Although it may end up with larger kernel image, it actually
>> allows more to be dropped once init is complete.
>
> It allows x86 to drop some code that it never needed in the first place.
>
> i don't think that is better :-)
>
> Maybe someone from x86-land can explain why they *keep* __exit
> code as they are the ones doing it wrong (/me ducks, runs and hides)

Oh, it can actually drop more. Please consider the following classes.

1. Stuff which are used during system init.
2. Stuff which are used during system init or hotplug.
3. Stuff which are used during hotplug.

ia64 way can express #1 and #3, x86 #1 and #2. #2 is superset of #3.
So, once init is complete, x86 way can drop larger set. What matters
is the memory consumption once init is complete, not the image size.
Anyways, in the end, the difference isn't really meaningful but I do
think that it would be far better to have unified behavior across
different architectures, one way or the other.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/