Re: Linux script to enable ASPM / Documentation for ASPM

From: Luis R. Rodriguez
Date: Mon Jun 21 2010 - 19:02:47 EST


On Mon, Jun 21, 2010 at 3:58 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote:
> ASPM was a dark magic when I first started looking at it. Some of it
> is still dark but what I was able to understand with the help of
> colleagues at work I've managed to stash here for now:
>
> http://wireless.kernel.org/en/users/Documentation/ASPM
>
> Then enabling ASPM was also quite a challenge and I always had to go
> back and revisit the procedures, so to help with that instead I wrote
> a script to do this for you correctly:
>
> http://kernel.org/pub/linux/kernel/people/mcgrof/aspm/enable-aspm
>
> Its sha1sum is: f5804fdab512065f219e55addf78c6654f1fc045
>
> If any of that looks confusing refer to the documentation above.
>
> There's a TODO there, so I'll get to the different items when I can
> but if you like feel free to send me patches as well:
>
> ÂTODO: patches are welcomed to me until we submit to to
> Â Â Â PCI Utilities upstream.
>
> ÂThis can be improved by in this order:
>
> Â Â Â Â* Accept arguments for endpoint and root complex address, and
> Â Â Â Â Âdesired ASPM settings
> Â Â Â Â* Look for your ASPM capabilities by quering your
> Â Â Â Â ÂLnkCap register first. Use these values to let you
> Â Â Â Â Âselect whether you want to enable only L1 or L1 & L0s
> Â Â Â Â* Searching for your root complex for you
> Â Â Â Â* Search for your PCI device by using the driver
> Â Â Â Â* Disable your driver and ask to reboot ?
> Â Â Â Â* Rewrite in C
> Â Â Â Â* Write ncurses interface [ wishlist ]
> Â Â Â Â* Write GTK/QT interface [ wishlist ]
> Â Â Â Â* Submit upstream as aspm.c to the PCI Utilities, which are
> Â Â Â Â Âmaintained by Martin Mares <mj@xxxxxx>

Come to think of it, would this be welcomed upstream in the PCI utils
as is for now?

Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/