Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80:Reworkprobing/JEDEC code

[Anton Vorontsov]

On Tue, Jun 22, 2010 at 02:37:52PM +0800, Barry Song wrote:
[...]
> > Â Â Â Â Â Â Â Âjid = jedec_probe(spi);
> > Â Â Â Â Â Â Â Âif (!jid) {
> > - Â Â Â Â Â Â Â Â Â Â Â dev_info(&spi->dev, "non-JEDEC variant of %s\n",
> > - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âid->name);
> > + Â Â Â Â Â Â Â Â Â Â Â return -ENODEV;
> The patch looks good to me. Only problem is NULL is also returned by
> spi_write_then_read() fail:
[...]
> Here much better for -EIO (return tmp)?

Agreed. Though, this is not a regression, and I guess desires
its own patch. 

Here are two patches, one for 2.6.35 (minimal changes to fix
the JEDEC problem), another for 2.6.36.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/