Re: [PATCH v2] block: Don't count_vm_events for discard bio in submit_bio.
From: Jens Axboe
Date: Thu Jun 24 2010 - 02:14:47 EST
On 2010-06-24 02:28, Tao Ma wrote:
> Hi Andrew,
>> Yes, that's a buglet.
>> Note that Christoph's "[PATCH, RFC] block: don't allocate a payload for
>> discard request" will fix it in a better way. That patch is in
>> linux-next now, but I expect it will be taken out again (quickly,
>> please) because Mike has found a number of problems with it.
> ok, I haven't noticed that. thanks for the info.
>> Your patch looks like a decent temporary fix for mainline, and a
>> permanent one for -stable.
> I am sorry, but I made a mistake. BIO_RW_DISCARD is a enum for bit offset.
> So the right check should be rw & (1 << BIO_RW_DISCARD).
> I have regenerated the patch. Sorry for the inconvenience.
Thanks, this one looks good. Applied.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/