Re: [PATCH 1/2] Staging: memrar: Moved memrar_allocator struct to memrar_allocator.c
From: Henri Häkkinen
Date: Thu Jun 24 2010 - 05:28:01 EST
On 24.6.2010, at 12.16, Alan Cox wrote:
>> +size_t memrar_allocator_largest_free_area(struct memrar_allocator *allocator)
>> + if (allocator == NULL)
>> + return 0;
>> + return allocator->largest_free_area;
> static ?
The entire point of these two patches was to hide the memrar_allocator structure by moving it to memrar_allocator.c, forward declaring it in memrar_allocator.h and then providing accessor functions memrar_allocator_largest_free_area and memrar_allocator_capacity (this was the #2 issue for memrar_allocator.[ch] in the TODO file). By defining memrar_allocator_largest_free_area function as static (this is what you mean, right?) would make no sense.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/