Re: [PATCH] USB: gadget: g_fs: code cleanup

From: Greg KH
Date: Fri Jun 25 2010 - 11:34:16 EST

On Fri, Jun 25, 2010 at 04:29:27PM +0200, Michal Nazarewicz wrote:
> This commit cleans the g_fs gadget hopefully making it more
> readable. This is achieved by usage of the usb_string_ids_tab()
> function for batch string IDs registration as well as
> generalising configuration so that a single routine is
> used to add each configuration and bind interfaces. As an
> effect, the code is shorter and has fewer #ifdefs.
> Moreover, in some circumstances previous code #defined
> CONFIG_USB_FUNCTIONFS_GENERIC macro to prevent a situation
> where gadget with no configurations is built. This code removes
> the #define form source code and achieves the same effect using
> select in Kconfig.
> This patch also changes wording and names of the Kconfig options.
> Signed-off-by: Michal Nazarewicz <m.nazarewicz@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
> I believe this was overlooked so I am resending this patch again.

Please always cc: me on patches you want applied, otherwise I very
easily overlook them due to the very large amount of email I get.


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at