Re: [RFC PATCH v2 4/5] skb: add tracepoints to freeing skb

From: Eric Dumazet
Date: Fri Jun 25 2010 - 16:06:01 EST

Le vendredi 25 juin 2010 Ã 16:12 +0900, Koki Sanagi a Ãcrit :

> > You might add a trace point to skb_free_datagram_locked() too, since it
> > contains an inlined consume_skb()
> >
> I think it is contrary.

I think you are _very_ wrong.

> skb_free_datagram_locked() contains consume_skb(), so tracepoint isn't needed.
> Because skb_free_datagram_locked() can be traced by trace_consume_skb().

Koki, it would be good if you worked on net-next-2.6, so that my comment

Also, not sending this kind of patches on netdev is not going to help
very much.

Who is supposed to review them on lkml and Ack them ?


Please build your future network related patches against net-next-2.6,
and send them to nedev and David Miller, the official network
maintainer, as stated in MAINTAINERS file.

M: "David S. Miller" <davem@xxxxxxxxxxxxx>
L: netdev@xxxxxxxxxxxxxxx
T: git git://
T: git git://
S: Maintained
F: net/
F: include/net/
F: include/linux/in.h
F: include/linux/net.h
F: include/linux/netdevice.h

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at