Re: [PATCH 1/2] block: fix leaks associated with discard request payload

From: Christoph Hellwig
Date: Sun Jun 27 2010 - 11:36:45 EST

On Sun, Jun 27, 2010 at 10:16:40AM -0400, Mike Snitzer wrote:
> My leak fixes have been tested extensively against all permuations of
> devices with discards (ATA trim, SCSI UNMAP, SCSI WRTIE SAME w/ unmap=1).
> I think we need to get Christoph's discard payload transformation
> complete by fixing the leaks _without_ trying to rework how discard
> commands are tagged, etc. E.g. fix what Jens already has staged in
> linux-2.6-block's 'for-next' and 'for-2.6.36'.
> With that sorted out we can then look at longer term changes to cleanup
> discard request processing.

I tend to agree. I'll look into getting rid of treating discards as
BLOCK_PC commands ontop of you patchset.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at