Re: [PATCH] arch/tile: Miscellaneous cleanup changes.

From: Chris Metcalf
Date: Sun Jun 27 2010 - 12:40:13 EST

On 6/26/2010 5:56 AM, Arnd Bergmann wrote:
> As far as I can tell, all the changes in this patch look reasonable, but
> as a rule you should never mix functional changes and cleanups in a single
> patch. This is both for review purposes as well as for being able to bisect
> specific regressions that might be introduced by the patch.

Yes, I'll try to be more precise with my commits in the future. I was
playing catch-up with a bunch of commits in our internal tree, which
uses Perforce. The change migration process doesn't lend itself to
pulling individual commits out of Perforce and into git, and I also
worried about spamming LKML with dozens of small patches for the tile
architecture, which after all hasn't even been pulled into Linus's tree
yet. And, of course, since few if any folks are actually running these
bits on their hardware yet (our hardware customers are likely all
running the sources we ship them), the bisection issue is less
critical. But I will at least make sure to separate out cleanups and
bugfixes going forward.


Chris Metcalf, Tilera Corp.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at