Re: [PATCH 2/2 v2] Driver core: reduce duplicated code

From: Uwe Kleine-König
Date: Mon Jun 28 2010 - 01:16:36 EST

Hi Eric,

On Mon, Jun 28, 2010 at 12:55:45PM +0800, Eric Miao wrote:
> I suggest you to have a look into arch/arm/mach-mmp/devices.c and
> arch/arm/mach-mmp/pxa{168,910}.c as well as
> arch/arm/mach-mmp/include/mach/pxa{168,910}.h, maybe we can find
> some common practice.
I think I like this approach in general, I already thought about not
passing all parameters as function/macro arguments, too. But maybe this
becomes too excessive for imx as I would need too many of these device
desc for the different imx variants?!

Anyhow a few things I thought when looking in the files you suggested:

- Why not use an array for all uart devdescs, maybe the code for
pxa168_add_uart could become a bit smaller then?:

extern struct pxa_device_desc pxa168_device_uart[2];
static inline int pxa168_add_uart(int id)
struct pxa_device_desc *d = pxa168_device_uart + id;

if (id < 0 || id > 2)
return -EINVAL;

return pxa_register_device(d, NULL, 0);

(Ditto for the other types obviously.)

- shouldn't all these pxa_device_descs and pxa168_add_$device functions
be __initdata and __init?

- pxa_register_device is better than my add_resndata function in (at
least) one aspect as it sets coherent_dma_mask, too. This is
something I missed when trying to add mxc-mmc (IIRC) devices.


Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | |
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at